Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update simple-service and simple-job example #144

Closed

Conversation

ffforest
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@ffforest ffforest added the enhancement New feature or request label Jan 11, 2024
@ffforest ffforest changed the title chore: update simple-service example and add prometheus/opsrule chore: update simple-service example and add prometheus and opsrule Jan 11, 2024
@ffforest ffforest changed the title chore: update simple-service example and add prometheus and opsrule chore: update simple-service and simple-job example Jan 11, 2024
@ffforest
Copy link
Contributor Author

Success of test-correctness depends on having new tagged version of catalog because fields interval, timeout and scheme have been removed from the schema after v0.1.1 which is the version the examples are using.

@ffforest ffforest force-pushed the chore-add-prometheus-example branch from e659e8f to 9bedb94 Compare January 11, 2024 07:40
@ffforest
Copy link
Contributor Author

Closing and re-open targeting develop-0.10.0 branch in #145

@ffforest ffforest closed this Jan 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants